Skip to content

feat(managedBy): explicit engine-owned lifecycle bucket (tracks framework ADR-0103 addendum)#2739

Merged
os-zhuang merged 1 commit into
mainfrom
refactor/managedby-engine-owned-bucket
Jul 20, 2026
Merged

feat(managedBy): explicit engine-owned lifecycle bucket (tracks framework ADR-0103 addendum)#2739
os-zhuang merged 1 commit into
mainfrom
refactor/managedby-engine-owned-bucket

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Mirrors the framework's engine-owned enum split (framework#3352, ADR-0103 addendum, tracking #3343) in the UI type + runtime + badge.

Stacked on #2724 (the userActions single-parser de-dup) — review/merge that first. The diff shown against main includes #2724's commit until it merges.

What changed (additive)

  • @object-ui/types — ManagedByBucket union + MANAGED_BY_BUCKETS gain 'engine-owned' (canonical order: platform, config, system, engine-owned, append-only, better-auth). The union stays closed, so any consumer that missed the value is a compile error.
  • @object-ui/core — resolveCrudAffordances gains the engine-owned default row (identical all-locked matrix to system/append-only), so isObjectInlineEditable and the grid/form gates treat it read-only automatically.
  • @object-ui/app-shell — ManagedByBadge renders engine-owned with the same read-only "System-managed" copy as a locked system object. It deliberately reuses the existing managedByBadge.system i18n key — zero translation churn across the 11 locales, consistent UX; the distinction is at the schema level, not the user-facing string. resolveManagedByEmptyState likewise reuses the system engine-owned empty state.

Behaviour-preserving

engine-owned resolves to the same locked affordances a locked system object did by default, so nothing about how a locked object renders changes — the value just makes the schema self-documenting. Type-check green across types/core/app-shell/plugin-{form,grid,detail}; core + app-shell suites green (1321); new unit coverage in resolveCrudAffordances / isObjectInlineEditable / MANAGED_BY_BUCKETS / the empty-state helper.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 20, 2026 7:13am

Request Review

Base automatically changed from refactor/managedby-dedup-useractions to main July 20, 2026 07:11
@os-zhuang @claude
feat(managedBy): add explicit engine-owned lifecycle bucket (tracks…
14dc786 
… framework ADR-0103 addendum, #3343)

Mirrors the framework's engine-owned enum split in the UI type + runtime + badge.

- @object-ui/types: `ManagedByBucket` union + `MANAGED_BY_BUCKETS` gain
  `'engine-owned'` (closed union → missed consumers are compile errors).
- @object-ui/core: `resolveCrudAffordances` DEFAULTS gains the engine-owned
  all-locked row (same matrix as system/append-only), so isObjectInlineEditable
  and the grid/form gates treat it read-only automatically.
- @object-ui/app-shell: ManagedByBadge renders engine-owned with the same
  read-only "System-managed" copy as a locked `system` object — reuses the
  existing `managedByBadge.system` i18n key (zero translation churn; the
  distinction is at the schema level). resolveManagedByEmptyState reuses the
  `system` engine-owned empty state.

Behaviour-preserving — engine-owned resolves to the same locked affordances a
locked `system` object did, so rendering is unchanged; the value just makes the
schema self-documenting. New unit coverage across resolveCrudAffordances /
isObjectInlineEditable / MANAGED_BY_BUCKETS / the empty-state helper.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@xuyushun441-sys
xuyushun441-sys force-pushed the refactor/managedby-engine-owned-bucket branch from 1379881 to 14dc786 Compare July 20, 2026 07:13
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-DaUzAE3T.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.10KB 97.86KB
core (index.js) 1.86KB 0.63KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 120.48KB 30.08KB
fields (index.js) 211.66KB 51.78KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.28KB 4.74KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.37KB 12.48KB
plugin-charts (index.js) 46.75KB 13.23KB
plugin-chatbot (index.js) 179.58KB 42.81KB
plugin-dashboard (index.js) 108.56KB 27.97KB
plugin-designer (index.js) 210.92KB 42.69KB
plugin-detail (index.js) 214.77KB 52.40KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 102.82KB 24.94KB
plugin-gantt (index.js) 162.24KB 39.49KB
plugin-grid (index.js) 174.13KB 45.90KB
plugin-kanban (index.js) 47.45KB 12.99KB
plugin-list (index.js) 98.18KB 23.20KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.64KB 20.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.02KB 0.95KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 31b77d4 into main Jul 20, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the refactor/managedby-engine-owned-bucket branch July 20, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: core package: types tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang